Add sourcelink to nuget package #297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #203 |
|
Sorry about the long delay reviewing this, I'll aim to get back around to it soon. |
|
@nblumhardt Proper SourceLink support would be handy in v3. |
|
ping @nblumhardt |
nblumhardt
requested changes
Jun 29, 2023
| @@ -20,6 +20,14 @@ | |||
| <RootNamespace>Serilog</RootNamespace> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup> | |||
There was a problem hiding this comment.
These can go in the long list of properties already present above; we only tend to use property groups when different conditions need to be applied.
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
| <IsPackable>true</IsPackable> |
There was a problem hiding this comment.
IsPackable already defaults to true so can be removed from this list.
sungam3r
reviewed
Mar 23, 2024
| @@ -36,6 +44,10 @@ | |||
| <PackageReference Include="Serilog.Sinks.Debug" Version="2.0.0" /> | |||
| <PackageReference Include="Serilog.Settings.Configuration" Version="3.3.0" /> | |||
| <PackageReference Include="Serilog.Formatting.Compact" Version="1.1.0" /> | |||
| <PackageReference Include="Microsoft.SourceLink.Github" Version="1.1.1"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve development/debugging experience